[PATCH] D75300: Support prefix padding for alignment purposes (Relaxable instructions only)

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 09:39:45 PDT 2020


reames updated this revision to Diff 250228.
reames added a comment.
Herald added a subscriber: dantrushin.

Per review comment, be more conservative about non-fully relaxed instructions.

I think the previous code was in fact correct, but given it doesn't help any practical test I know of, being super conservative is reasonable for now.

Can I get an LGTM on this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75300/new/

https://reviews.llvm.org/D75300

Files:
  llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp
  llvm/test/MC/X86/align-via-padding.s
  llvm/test/MC/X86/align-via-relaxation.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75300.250228.patch
Type: text/x-patch
Size: 9755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200313/46b6045d/attachment.bin>


More information about the llvm-commits mailing list