[PATCH] D76129: Fix possible assertion when using PBQP with debug info

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 07:28:37 PDT 2020


danilaml added a comment.

Test generated from the following C code:

  #include <stdint.h>
  
  void test(int16_t* a, int16_t* b, int16_t* c, uint32_t n) {
      for (int32_t i = 0; i < n; i++) {
          *c++ = *a++ + *b++;
      }
  }



================
Comment at: llvm/lib/CodeGen/CalcSpillWeights.cpp:217
 
     numInstr++;
+    if (mi->isIdentityCopy() || mi->isImplicitDef())
----------------
Don't think that counting uses in debug instrs was originally intended for this heuristic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76129/new/

https://reviews.llvm.org/D76129





More information about the llvm-commits mailing list