[PATCH] D76057: [Reassociate] recognize more than one pairs for later CSE - NFC

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 04:24:34 PDT 2020


shchenz planned changes to this revision.
shchenz added a comment.

In D76057#1921261 <https://reviews.llvm.org/D76057#1921261>, @fhahn wrote:

> I think it would make the review much easier if the description would include the rational behind the changes, i.e how the patch works, why the changes are necessary in terms of implementation and what issue the patch concretely addressed.
>
> Also you mention follow-on changes that build on this one.  Sharing them would probably also help with reviewing this change, to see how things fit together in the end. Phabricator lets you link related/dependent patches.


Make sense. I will ask for reviewing when follow-on patch is ready. Thanks for your comment @fhahn


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76057/new/

https://reviews.llvm.org/D76057





More information about the llvm-commits mailing list