[PATCH] D69891: [VP,Integer,#1] Vector-predicated integer intrinsics

Fri Mar 13 03:41:35 PDT 2020

simoll added a comment.

In D69891#1921183 <https://reviews.llvm.org/D69891#1921183>, @fhahn wrote:

> In D69891#1921124 <https://reviews.llvm.org/D69891#1921124>, @simoll wrote:
>
> > In D69891#1919830 <https://reviews.llvm.org/D69891#1919830>, @andrew.w.kaylor wrote:
> >
> > > OK. Since the behavior for out-of-range evl is target-dependent, undefined makes sense.
> > >
> > > I don't know if you were waiting for input from anyone else, but this looks good to me.
> >
> >
> > Great :) Thanks to everybody involved for reviewing!
> >  We've iterated on this patch for a while and the last major update was weeks ago, giving people enough time to react to it. I'll commit this today.
>
>
> Given the scale of the change, it might be good to let people on llvm-dev know that a this patch is ready to land and it is about to be committed (and wait till early next week in case there's additional feedback).

Ok, let's wait until next week to give people more time to react. I will also update the reference patch in the main RFC noting that the integer VP patch was accepted.
However, i don't think it is necessary to bring this particular patch up on llvm-dev - there were several llvm-dev mails regarding VP in the past and we should have all interested parties as subscribers to the main RFC. Future patches are a completely different story - eg the VP-expansion pass and follow up patches should be announced on llvm-dev to make sure everybody is aware of them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69891/new/

https://reviews.llvm.org/D69891