[PATCH] D75297: [TypeSize] Allow returning scalable size in implicit conversion to uint64_t

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/CMakeLists.txt:426
+# SVE/SVE2 or other scalable vector architectures.
+option(LLVM_ENABLE_STRICT_IMPLICIT_CONVERSION_TYPESIZE "Enable assertions that type is not scalable in implicit conversion from TypeSize to uint64_t" OFF)
+
----------------
efriedma wrote:
> 80 columns
The convention in this file doesn't seem to honour 80 chars. I've put the message on a separate line similar to how this is done for other options.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULibFunc.cpp:608
   char const TC = param.front();
-  if (::isDigit(TC)) {
+  if (isDigit(TC)) {
     res.ArgType = StringSwitch<AMDGPULibFunc::EType>
----------------
efriedma wrote:
> Unrelated change?
`llvm/Support/WithColor.h` indirectly includes `llvm/ADT/StringExtras.h` which also defines a `isDigit` function. That makes this call ambiguous with the `isDigit` defined in this file. 
The better fix is probably to remove the local isDigit and include StringExtras.h in this file directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75297/new/

https://reviews.llvm.org/D75297