[PATCH] D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops.

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 18:20:33 PDT 2020


mravishankar accepted this revision.
mravishankar added inline comments.


================
Comment at: mlir/test/Dialect/Linalg/loops.mlir:243
+//       CHECK:                 %[[SUM1:.*]] = affine.apply #{{.*}}(%{{.*}}, %{{.*}})
+//       CHECK:                 %[[IDX:.*]] = affine.max {{.*}}(%[[SUM0]])
+//       CHECK:                 %[[IDY:.*]] = affine.max {{.*}}(%[[SUM1]])
----------------
Nit : Since you are generating the affine map in this change, better to check that you have the right affine map.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75722/new/

https://reviews.llvm.org/D75722





More information about the llvm-commits mailing list