[PATCH] D76112: NFC - Removed unnecessary StandardOp includesA number of transform import StandardOps despite notbeing dependent on it. Cleaned it up to better understandwhat dialects each of these transforms depend on.

Rob Suderman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 17:43:07 PDT 2020


rsuderman created this revision.
Herald added subscribers: llvm-commits, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
rsuderman retitled this revision from "NFC - Removed unnecessary StandardOp includes

A number of transform import StandardOps despite not
being dependent on it. Cleaned it up to better understand
what dialects each of these transforms depend on." to "NFC - Removed unnecessary StandardOp includesA number of transform import StandardOps despite notbeing dependent on it. Cleaned it up to better understandwhat dialects each of these transforms depend on.".
rsuderman added a reviewer: rriddle.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76112

Files:
  mlir/lib/Transforms/AffineLoopInvariantCodeMotion.cpp
  mlir/lib/Transforms/LoopCoalescing.cpp
  mlir/lib/Transforms/LoopFusion.cpp
  mlir/lib/Transforms/PipelineDataTransfer.cpp
  mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
  mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
  mlir/lib/Transforms/Utils/Utils.cpp


Index: mlir/lib/Transforms/Utils/Utils.cpp
===================================================================
--- mlir/lib/Transforms/Utils/Utils.cpp
+++ mlir/lib/Transforms/Utils/Utils.cpp
@@ -19,7 +19,6 @@
 #include "mlir/Analysis/Dominance.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/AffineOps/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/IR/Function.h"
 #include "mlir/IR/Module.h"
Index: mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
===================================================================
--- mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
+++ mlir/lib/Transforms/Utils/LoopFusionUtils.cpp
@@ -17,7 +17,6 @@
 #include "mlir/Analysis/LoopAnalysis.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/AffineOps/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/AffineExpr.h"
 #include "mlir/IR/AffineMap.h"
 #include "mlir/IR/BlockAndValueMapping.h"
Index: mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
===================================================================
--- mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
+++ mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
@@ -10,7 +10,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/IR/PatternMatch.h"
 #include "mlir/Transforms/FoldUtils.h"
Index: mlir/lib/Transforms/PipelineDataTransfer.cpp
===================================================================
--- mlir/lib/Transforms/PipelineDataTransfer.cpp
+++ mlir/lib/Transforms/PipelineDataTransfer.cpp
@@ -16,7 +16,6 @@
 #include "mlir/Analysis/LoopAnalysis.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/AffineOps/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Transforms/LoopUtils.h"
Index: mlir/lib/Transforms/LoopFusion.cpp
===================================================================
--- mlir/lib/Transforms/LoopFusion.cpp
+++ mlir/lib/Transforms/LoopFusion.cpp
@@ -15,7 +15,6 @@
 #include "mlir/Analysis/LoopAnalysis.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/AffineOps/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/AffineExpr.h"
 #include "mlir/IR/AffineMap.h"
 #include "mlir/IR/Builders.h"
Index: mlir/lib/Transforms/LoopCoalescing.cpp
===================================================================
--- mlir/lib/Transforms/LoopCoalescing.cpp
+++ mlir/lib/Transforms/LoopCoalescing.cpp
@@ -7,7 +7,6 @@
 //===----------------------------------------------------------------------===//
 
 #include "mlir/Dialect/LoopOps/LoopOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/Pass/Pass.h"
 #include "mlir/Transforms/LoopUtils.h"
 #include "mlir/Transforms/Passes.h"
Index: mlir/lib/Transforms/AffineLoopInvariantCodeMotion.cpp
===================================================================
--- mlir/lib/Transforms/AffineLoopInvariantCodeMotion.cpp
+++ mlir/lib/Transforms/AffineLoopInvariantCodeMotion.cpp
@@ -16,7 +16,6 @@
 #include "mlir/Analysis/SliceAnalysis.h"
 #include "mlir/Analysis/Utils.h"
 #include "mlir/Dialect/AffineOps/AffineOps.h"
-#include "mlir/Dialect/StandardOps/IR/Ops.h"
 #include "mlir/IR/AffineExpr.h"
 #include "mlir/IR/AffineMap.h"
 #include "mlir/IR/Builders.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76112.250107.patch
Type: text/x-patch
Size: 3489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200313/8d5a1ae1/attachment.bin>


More information about the llvm-commits mailing list