[PATCH] D76107: AMDGPU: Don't handle kernarg.segment.ptr in functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 17:23:27 PDT 2020


arsenm added a comment.

In D76107#1920704 <https://reviews.llvm.org/D76107#1920704>, @rampitec wrote:

> A trap would be better, we can easily spot it.




In D76107#1920704 <https://reviews.llvm.org/D76107#1920704>, @rampitec wrote:

> A trap would be better, we can easily spot it.


A trap isn’t particularly different from the null dereference if you try to actually use it. I was leaning more towards a compile time error


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76107/new/

https://reviews.llvm.org/D76107





More information about the llvm-commits mailing list