[PATCH] D75870: [mlir][spirv] Add a pass to deduce version/extension/capability

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 3 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/Transforms/UpdateVCEPass.cpp:121
+      for (const auto &ors : capabilities.getCapabilities()) {
+        bool satisfied = false; // True when at least one capability can be used
+        for (spirv::Capability cap : ors) {
----------------
rriddle wrote:
> nit: Move the comment before the variable.
I think this way it reads more naturally.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75870/new/

https://reviews.llvm.org/D75870