[PATCH] D75875: [mlir][spirv] Support querying type extension/capability requirements

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

Just a few nits. Nice to see everything threaded through!



================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVTypes.h:276
+  /// Range class for element types.
+  class ElementTypeRange
+      : public ::mlir::detail::indexed_accessor_range_base<
----------------
THis is a nice addition!


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVTypes.cpp:583
+    LLVM_FALLTHROUGH;
+  case StorageClass::Input:
+  case StorageClass::Output:
----------------
So input/output cant be 8 bit?


================
Comment at: mlir/lib/Dialect/SPIRV/Transforms/UpdateVCEPass.cpp:75
+/// convention.
+static LogicalResult checkAndUpdateCapabilityRequirements(
+    Operation *op,
----------------
This and the above method are the same. Could just template this to reduce bloat


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75875/new/

https://reviews.llvm.org/D75875