[PATCH] D75972: [QuantOps] Add the quant region definition

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/QuantOps/IR/QuantOps.cpp:49
+    Type spec = typeAttr.getValue();
+    if (spec.isa<TensorType>() || spec.isa<VectorType>()) {
+      return false;
----------------
nit: Remove all trivial braces.


================
Comment at: mlir/lib/Dialect/QuantOps/IR/QuantOps.cpp:52
+    }
+    /// The spec should be either a quantized type which is compatible to the
+    /// expressed type, or a primitive type which is as same as the
----------------
nit: Use // for comments when inside of functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75972/new/

https://reviews.llvm.org/D75972