[PATCH] D75888: [mlir][SideEffects] Mark the CFG only terminator operations as NoSideEffect

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Transforms/CSE.cpp:127
+  // Don't simplify terminator operations.
+  if (op->isKnownTerminator())
+    return failure();
----------------
herhut wrote:
> This might still simplify terminator operations that we do not identify as those. Is the idea that those still have to remain side-effecting? Or will this be fixed in a future iteration with more detailed modelling?
CSE/DCE doesn't modify the CFG(terminators) generally, so this check will remain the same regardless of effect modeling.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75888/new/

https://reviews.llvm.org/D75888