[PATCH] D74205: [llvm-dwarfdump] Add the --show-sections-sizes option

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/SectionSizes.cpp:56-60
+  return SectionName.startswith(".debug") ||
+         SectionName.startswith("__debug") ||
+         SectionName.startswith(".zdebug") ||
+         SectionName.startswith("__zdebug") || SectionName == ".gdb_index" ||
+         SectionName == "__gdb_index";
----------------
jhenderson wrote:
> I think the naming here needs to be format specific unfortunately, as "__debug" is not a debug section for ELF. Perhaps not worth worrying about though...?
I agree, that is why I would keep this function local to `llvm-dwarfdump`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74205/new/

https://reviews.llvm.org/D74205