[PATCH] D75908: [SCEV] isHighCostExpansionHelper(): use correct TTI hooks

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 09:13:14 PDT 2020


lebedev.ri added a comment.

In D75908#1919587 <https://reviews.llvm.org/D75908#1919587>, @reames wrote:

> In D75908#1916313 <https://reviews.llvm.org/D75908#1916313>, @samparker wrote:
>
> > Agreed that it's broken, but it looks like SCEV expander is the only place that this API is/was used. Can we now remove getOperationCost?
>
>
> If the code is dead, sure.  That's a great way to fix broken code.  :)


+1. If it's really not used let's drop it. It was mis-used twice already in just last month or so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75908/new/

https://reviews.llvm.org/D75908





More information about the llvm-commits mailing list