[PATCH] D75509: [mlir] Removed TanHOp lowering from ConvertStandardToLLVM since there is no reasonable TanH representation in LLVM.

Thu Mar 12 07:35:56 PDT 2020

herhut accepted this revision.
herhut added a comment.

Can this land or has it already?

================
Comment at: mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp:689
-    target.addDynamicallyLegalOp<mlir::LLVM::CallOp>(
-        gpu::filterIllegalLLVMIntrinsics({"tanh", "tanhf"}, m.getContext()));
     // TODO(csigg): Remove once we support replacing non-root ops.
----------------
Could you also remove the `filterIllegalLLVMIntrinsics` if it is now unused? It was a hack to unbreak the windows build and we should remove it to prevent others from starting to use it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75509/new/

https://reviews.llvm.org/D75509