[llvm] 4689eae - [X86] combineOrShiftToFunnelShift - remove shift by immediate handling.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 04:47:54 PDT 2020


Author: Simon Pilgrim
Date: 2020-03-12T11:46:51Z
New Revision: 4689eae8204ca62e36adf174e5833e8c22e01a78

URL: https://github.com/llvm/llvm-project/commit/4689eae8204ca62e36adf174e5833e8c22e01a78
DIFF: https://github.com/llvm/llvm-project/commit/4689eae8204ca62e36adf174e5833e8c22e01a78.diff

LOG: [X86] combineOrShiftToFunnelShift - remove shift by immediate handling.

Now that D75114 has landed, DAGCombiner handles this case so the code is redundant.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 4c86c87fb33b..87e65038c6fb 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -41626,10 +41626,6 @@ static SDValue combineOrShiftToFunnelShift(SDNode *N, SelectionDAG &DAG,
           ShAmt1Op1 == ShAmt0)
         return GetFunnelShift(Op0, Op1, ShAmt0);
     }
-  } else if (auto *ShAmt1C = dyn_cast<ConstantSDNode>(ShAmt1)) {
-    auto *ShAmt0C = dyn_cast<ConstantSDNode>(ShAmt0);
-    if (ShAmt0C && (ShAmt0C->getSExtValue() + ShAmt1C->getSExtValue()) == Bits)
-      return GetFunnelShift(Op0, Op1, ShAmt0);
   } else if (ShAmt1.getOpcode() == ISD::XOR) {
     SDValue Mask = ShAmt1.getOperand(1);
     if (auto *MaskC = dyn_cast<ConstantSDNode>(Mask)) {


        


More information about the llvm-commits mailing list