[PATCH] D75966: [ELF] Move --print-map(-M)/--cref before checkSections() and openFile()

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with 2 nits.



================
Comment at: lld/test/ELF/linkerscript/output-too-large.s:8
+# RUN: not ld.lld -T %t1.script %t1.o -M -o /dev/null 2>&1 | \
+# RUN:   FileCheck --check-prefixes=MAP1 %s
+
----------------
MaskRay wrote:
> grimar wrote:
> > `MAP1,CHECK`?
> `error: output file too large` is not printed for this test.
Then you should use `--check-prefix`, not `--check-prefixes`.


================
Comment at: lld/test/ELF/linkerscript/output-too-large.s:7
 
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
-# RUN: echo "SECTIONS { .text : { . = 0x8fffffffffffffff; *(.text*); } }" > %t.script
-# RUN: not ld.lld --no-check-sections --script %t.script %t.o -o /dev/null 2>&1 | FileCheck %s
+## Error if an address can be greater than or equal to 2**32 for ELF32.
+## When -M is specified, print the link map even if such an error occurs,
----------------
Perhaps, "..if an address is greater..."?
I think an address always _can_, but we report the case when it _is_ :)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75966/new/

https://reviews.llvm.org/D75966