[PATCH] D76050: [LoopPeel] Remove incorrect assertion in countToEliminateCompares

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 02:20:02 PDT 2020


fedor.sergeev added a comment.

> @lebedev.ri I am not sure what your logic implied here; maybe instead of removal of assert this check should be a part of if for profitability reasons.

In review where this assert was introduced in one of the previous versions of it there was a check instead of assert (see line 261+:    https://reviews.llvm.org/D69617?id=227953)
I believe doing this check makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76050/new/

https://reviews.llvm.org/D76050





More information about the llvm-commits mailing list