[PATCH] D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops.

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 00:52:37 PDT 2020


mravishankar requested changes to this revision.
mravishankar added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp:188
+    SmallVector<ValueHandle, 8> conds;
+    for (auto iter : llvm::enumerate(imIdx)) {
+      using edsc::op::operator<;
----------------
you only need to iterate over the "window" dimensions. No need to check these conditions on the batch or channels dimensions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75722/new/

https://reviews.llvm.org/D75722





More information about the llvm-commits mailing list