[PATCH] D71027: Support repeated machine outlining

[Jin Lin via Phabricator via llvm-commits]

jinlin added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:102
+static cl::opt<unsigned>
+    NumRepeat("outline-repeat-count", cl::Hidden,
+              cl::desc("The number of times to apply outlining"), cl::init(1));
----------------
tellenbach wrote:
> Could we rename this to something like `machine-outline-repeat-counts` or `machine-outline-runs`? The term `outlining` itself is somewhat ambigious and the prefix `machine` would be more consistent.
Done.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:103
+    NumRepeat("outline-repeat-count", cl::Hidden,
+              cl::desc("The number of times to apply outlining"), cl::init(1));
+
----------------
tellenbach wrote:
> Same here: I suggest something like *...to apply machine outlining*
Done.


================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1510
+bool MachineOutliner::runOnModule(Module &M) {
+  unsigned NumRepeats = NumRepeat;
+  if (NumRepeats < 1)
----------------
tellenbach wrote:
> Why is this indirection necessary?
I have removed this extra variable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71027/new/

https://reviews.llvm.org/D71027