[PATCH] D75585: Add debug info support for Swift/Clang APINotes.

Wed Mar 11 18:10:25 PDT 2020

aprantl marked an inline comment as done.
aprantl added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:412
 // Apple extensions.
+HANDLE_DW_AT(0x3e07, APPLE_apinotes, 0, APPLE)
 HANDLE_DW_AT(0x3fe1, APPLE_optimized, 0, APPLE)
----------------
davide wrote:
> aprantl wrote:
> > I'm fine with calling this `DW_AT_LLVM_apinotes`, too.
> I'd rather call them LLVM_apinotes, but I don't have a strong opinion about it.
I carefully chose the number out of the LLVM space already, so the constant could be renamed once it's upstream. But I'm fine with naming it LLVM from the start.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75585/new/

https://reviews.llvm.org/D75585