[PATCH] D76000: AMDGPU: Don't hard error on LDS globals in functions

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 15:56:48 PDT 2020


yaxunl added a comment.

In D76000#1918031 <https://reviews.llvm.org/D76000#1918031>, @arsenm wrote:

> In D76000#1917991 <https://reviews.llvm.org/D76000#1917991>, @yaxunl wrote:
>
> > So we will never be able to debug a HIP program compiled with -O0 where a device function uses shared variable since all functions are noinilne. This seems quite a restriction.
>
>
> I'm strongly opposed to clang using noinline at -O0. This should be stopped


I will see if I can change that, at least for HIP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76000/new/

https://reviews.llvm.org/D76000





More information about the llvm-commits mailing list