[PATCH] D75944: [x86][seses] Don't LFENCE data invariant insts

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 15:56:47 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:129
+      // data invariant instructions, then continue to the next instruction.
+      if (!LFENCEDataInvariantInstructions &&
+          (TII->isDataInvariant(MI) || TII->isDataInvariantLoad(MI))) {
----------------
Don't the instructions that match isDataInvariantLoad still pull things into the cache?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75944/new/

https://reviews.llvm.org/D75944





More information about the llvm-commits mailing list