[PATCH] D75883: Add Builder::getI64VectorAttr.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 15:20:12 PDT 2020


silvas added inline comments.


================
Comment at: mlir/lib/IR/Builders.cpp:109
+DenseIntElementsAttr Builder::getI64VectorAttr(ArrayRef<int64_t> values) {
+  return DenseElementsAttr::get(
+             VectorType::get(static_cast<int64_t>(values.size()),
----------------
bondhugula wrote:
> AFAIR, you can just do ```DenseIntElementsAttr::get``` - you don't need the trailing cast. The method right above can also be fixed the same way.
Done!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75883/new/

https://reviews.llvm.org/D75883





More information about the llvm-commits mailing list