[PATCH] D75892: [InstSimplify][SVE] Fix SimplifyGEPInst for scalable vector.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 13:35:29 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/test/Transforms/InstSimplify/vscale.ll:14
+  ret <vscale x 4 x i32*> %ptr
+}
+
----------------
@getelementptr_1 passes without this patch, right?


================
Comment at: llvm/test/Transforms/InstSimplify/vscale.ll:22
+  ret <vscale x 4 x <vscale x 4 x i32>*> %ptr
+}
+
----------------
Please add testcases with a vscale'ed source type that doesn't simplify to a constant.

Please add a testcase like `getelementptr <vscale x 4 x i32>, <vscale x 4 x i32>* null, i64 %x` (where the return type is a pointer to a vector, rather than a vector of pointers to vectors).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75892/new/

https://reviews.llvm.org/D75892





More information about the llvm-commits mailing list