[PATCH] D75868: [mlir][spirv] Use separate attribute for (version, capabilities, extensions)

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h:59
+                           MLIRContext *context);
+  static VerCapExtAttr get(IntegerAttr version, ArrayAttr capabilities,
+                           ArrayAttr extensions);
----------------
mravishankar wrote:
> Nit: can you just take an integer here?
This constructor's purpose is to avoid recreating the IntegerAttr if already having one. So I have it this one. Normally one should use the above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75868/new/

https://reviews.llvm.org/D75868