[PATCH] D76013: [GC] Loosen ordering on statepoint reloads to allow CSE

Denis Antrushin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 11:53:21 PDT 2020


dantrushin accepted this revision.
dantrushin added a comment.
This revision is now accepted and ready to land.

Wow. That simple.
LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp:978
+  // statepoints (i.e. no other aliasing stores); informing SelectionDAG of
+  // this this let's CSE kick in for free and allows reordering of instructions
+  // if possible.  The lowering for statepoint sets the root, so this is
----------------
Typo? Should this read '...this lets ...' ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76013/new/

https://reviews.llvm.org/D76013





More information about the llvm-commits mailing list