[PATCH] D75973: [mlir] Add support for non-identifier attribute names.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 09:37:18 PDT 2020


silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

Nice improvement! Thanks for the quick turnaround :)



================
Comment at: mlir/lib/IR/AsmPrinter.cpp:1622
+  } else {
+    os << "\"";
+    printEscapedString(attr.first.strref(), os);
----------------
nit: '"' for consistency with below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75973/new/

https://reviews.llvm.org/D75973





More information about the llvm-commits mailing list