[PATCH] D75915: [GlobalISel] combine G_TRUNC with G_MERGE_VALUES

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 09:37:12 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/artifact-combiner-trunc.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -O0 -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -run-pass=legalizer -global-isel-abort=0 %s -o - | FileCheck %s
+
----------------
Can probably remove -global-isel-abort=0


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/artifact-combiner-trunc.mir:98
+    $vgpr0 = COPY %4
+...
----------------
Should add some cases with pointers to catch the isScalar checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75915/new/

https://reviews.llvm.org/D75915





More information about the llvm-commits mailing list