[PATCH] D73600: [Matrix] Add remark propagation along the inlined-at chain.

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

In the description when you say:

> We then generate remarks using the list of instructions for
>  each subprogram. This allows surfacing the remarks at a level useful to
>  users.

I would make it explicit that here subprograms is meant to include its own subprograms recursively.  E.g. using the example for the subprogram test this includes load and store inlined functions.

LGTM with these.



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1208
+  //     mapping.  Leaves are lowered matrix instructions without other matrix
+  //     users (like stores) in the current subprogram.
+  /// 3. For each leaf, create a remark containing a linearizied version of the
----------------
Also explain why we need leaves and what that means for sharing.  Again an example would be useful.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1223
+    /// Return all leafs of the expressions in \p ExprsInSubprogram. Those are
+    /// instructions in Inst2ColumnMatrix returing void or without any users in
+    /// \p ExprsInSubprogram. Currently that should only include stores.
----------------
returning


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73600/new/

https://reviews.llvm.org/D73600