[PATCH] D76000: AMDGPU: Don't hard error on LDS globals in functions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 09:04:43 PDT 2020


arsenm created this revision.
arsenm added reviewers: rampitec, t-tye, yaxunl.
Herald added subscribers: kerbowa, hiraditya, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

Instead, emit a trap and a warning. We force inlining of this
situation, so any function where this happens should be dead as
indirect or external calls are not yet supported. This should avoid
erroring on dead code.


https://reviews.llvm.org/D76000

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAnnotateKernelFeatures.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/lds-global-non-entry-func.ll
  llvm/test/CodeGen/AMDGPU/lds-global-non-entry-func.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76000.249647.patch
Type: text/x-patch
Size: 10406 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200311/6ae5d23d/attachment-0001.bin>


More information about the llvm-commits mailing list