[PATCH] D70720: [llvm-objdump] Display locations of variables alongside disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:8
+
+## The han character in the source does not print correctly on windows.
+# UNSUPPORTED: system-windows
----------------
Nit: windows -> Windows

It might be wise to change "han" -> "'喵'" as I don't know what the "han" character is.


================
Comment at: llvm/test/tools/llvm-objdump/ARM/debug-vars-wide-chars.s:12
+## Check that the --debug-vars option correctly aligns the variable display when
+## the source code (printed by the -S option) includes east asian wide
+## characters.
----------------
Nit: east asian -> East Asian

(I think)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70720/new/

https://reviews.llvm.org/D70720