[PATCH] D75192: [mlir][vulkan-runner] Update mlir-vulkan-runner execution driver.

Denis Khalikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 02:19:24 PDT 2020


denis13 marked an inline comment as done.
denis13 added inline comments.


================
Comment at: mlir/lib/Conversion/GPUToVulkan/ConvertLaunchFuncToVulkanCalls.cpp:131
+    // 4. Stride in dim 0.
+    return {operands[numConfigOps + index * loweredMemRefNumOps1D],
+            operands[numConfigOps + index * loweredMemRefNumOps1D + 3]};
----------------
rriddle wrote:
> This breaks on GCC5:
> https://buildkite.com/mlir/mlir-core/builds/3336#3ba0b41b-c8d6-4ce6-9788-dc12c51a4024
Sorry about it, Lei already fixed it https://github.com/llvm/llvm-project/commit/5b0c60c58ea426b215cfd2970c9eaa6eb5b42026


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75192/new/

https://reviews.llvm.org/D75192





More information about the llvm-commits mailing list