[PATCH] D75919: Teach the MLIR AsmPrinter to correctly escape asm names that use invalid characters.

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 23:00:28 PDT 2020


lattner added a comment.

> Also, what about using a string as the escape mechanism?

I'm open to this.  This this what Swift does, where you can have an identifier x, or you can have an identifier `x` that allows a very generous grammar within it.

In this case, I don't think we want to promise to dialects that the textual IR will persist an arbitrary grammar.  I think it is better to keep the asm format simple, and force dialects who care about this stuff (none of them today, and almost none of them in the future) to own the autorenaming complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75919/new/

https://reviews.llvm.org/D75919





More information about the llvm-commits mailing list