[PATCH] D75919: Teach the MLIR AsmPrinter to correctly escape asm names that use invalid characters.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 23:00:23 PDT 2020


rriddle added a comment.

In D75919#1915161 <https://reviews.llvm.org/D75919#1915161>, @rriddle wrote:

> What is the benefit of doing this vs. just rejecting/ignoring the name? Do we need to support the weird cases?


Also, what about using a string as the escape mechanism? We already do this for other things.

  %"a .^x" : i32


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75919/new/

https://reviews.llvm.org/D75919





More information about the llvm-commits mailing list