[PATCH] D75649: [mlir] Introduce OwningFuncRef following the same pattern as OwningModuleRef

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 22:17:01 PDT 2020


mehdi_amini added a comment.

> using `OpBuilder::create` is much more idiomatic with the rest of the infra.

The builder APIs don't express clear ownership though, having a RAII type would be nice!
Could the OpBuilder::create always return an OwningOpRef<OpTy> ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75649/new/

https://reviews.llvm.org/D75649





More information about the llvm-commits mailing list