[PATCH] D74919: AMDGPU/GlobalISel: Manually RegBankSelect copies

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 21:34:02 PDT 2020


qcolombet accepted this revision.
qcolombet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp:2993
+                                             *TRI);
+    if (!SrcBank) // FIXME: Why would we see this?
+      SrcBank = &AMDGPU::VGPRRegBank;
----------------
You should be able to assert on this, like you suspected in your comment.

We use RPO, so sources should have been assigned at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74919/new/

https://reviews.llvm.org/D74919





More information about the llvm-commits mailing list