[PATCH] D74691: [Attributor] Detect possibly unbounded cycles in functions

Tue Mar 10 19:42:03 PDT 2020

baziotis added a comment.

In D74691#1915962 <https://reviews.llvm.org/D74691#1915962>, @omarahmed wrote:

> In D74691#1915859 <https://reviews.llvm.org/D74691#1915859>, @baziotis wrote:
>
> > I added a single nit comment. Otherwise it LGTM! :)
>
>
> Thanks for the great reviews and bearing my small mistakes through this :)

No problem, I hope it helped. :) Let's wait for a couple of days for other reviewers and then I can commit.

Although I just saw we should also change the commit message (i.e. the description).
The following is a quick write that seems fine.

Add mayContainUnboundedCycle which checks if there's a cycle
in a function that we consider unbounded.
All loops with max trip count are considered bounded.
Any other cycle is not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691