[PATCH] D75908: [SCEV] isHighCostExpansionHelper(): use correct TTI hooks

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 18:05:29 PDT 2020


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.

Though, I'll comment that this interface is broken.  If the generically named function doesn't do the same thing as the specifically named version given the same arguments, that's a bug in the API design.  The only one of these which is defensible is the select changes.  The LGTM is because this is a generic problem, and I don't want to block progress in this specific area on the generic fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75908/new/

https://reviews.llvm.org/D75908





More information about the llvm-commits mailing list