[PATCH] D74576: GlobalISel: Don't try to narrow extending loads/trunc store

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 14:46:33 PDT 2020


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

This seems reasonable to me.



================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3125-3126
+  // FIXME: Do we need a distinct NarrowMemory legalize action?
+  if (ValTy.getSizeInBits() != 8 * MMO->getSize())
+    return UnableToLegalize;
+
----------------
Can we have some debug output explaining what's happening here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74576/new/

https://reviews.llvm.org/D74576





More information about the llvm-commits mailing list