[PATCH] D75081: [CodeView] Align type records on 4-bytes when emitting PDBs

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 14:46:27 PDT 2020


aganea updated this revision to Diff 249496.
aganea edited the summary of this revision.
aganea added reviewers: amccarth, ruiu.
aganea added subscribers: amccarth, hans, ruiu.
aganea added a comment.

Updated with better test.
I've moved the test in LLD because I can't find a codepath in LLVM that uses the `TypeStreamMerger` with OBJs as inputs and outputting into a PDB. The closest is `llvm-pdbutil merge ...` but that only takes TypeServer PDBs as inputs.

Adding more people:
+ at amccarth
+ at ruiu for the LLD test.
+ at hans : This occurs in release/10.x but it's probably there for a long time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75081/new/

https://reviews.llvm.org/D75081

Files:
  lld/test/COFF/pdb-tpi-aligned-records.test
  llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h
  llvm/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
  llvm/lib/DebugInfo/PDB/Native/TpiStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75081.249496.patch
Type: text/x-patch
Size: 5777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200310/80ec49f7/attachment.bin>


More information about the llvm-commits mailing list