[PATCH] D75790: [PowerPC] Fix compile time issue

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 13:39:52 PDT 2020


MaskRay added a comment.

Generally looks good, but the title needs to be clarified. This piece of code is related to an optimization which uses CTR as the loop count register.

For context, D6786 <https://reviews.llvm.org/D6786> introduced `mightUseCTR`.  rL251582 <https://reviews.llvm.org/rL251582> made it recurse into the constant.

IIUC, with ThinLTO's ImportConstantsWithRefs optimization, a constant can be very large, and recursing into it for every instruction can make the compilation slow. Is that the case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75790/new/

https://reviews.llvm.org/D75790





More information about the llvm-commits mailing list