[PATCH] D75869: [mlir][spirv] Use larger range for target environment lookup function

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 11:25:32 PDT 2020


mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/SPIRV/TargetAndABI.cpp:298
 spirv::TargetEnvAttr spirv::lookupTargetEnvOrDefault(Operation *op) {
-  if (auto attr = op->getAttrOfType<spirv::TargetEnvAttr>(
-          spirv::getTargetEnvAttrName()))
-    return attr;
+  for (Operation *symTable = op; symTable; symTable = symTable->getParentOp()) {
+    symTable = SymbolTable::getNearestSymbolTable(symTable);
----------------
Nit: make this a while loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75869/new/

https://reviews.llvm.org/D75869





More information about the llvm-commits mailing list