[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 10:53:16 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp:63
 private:
+  // Returns personality of `f` as a FlatSymbolRefAttr.
+  FlatSymbolRefAttr getPersonalityAsAttr(llvm::Function *f);
----------------
rriddle wrote:
> nit: // -> ///
(sigh, looks like the display is messed up)
nit: Use /// for top-level comments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888





More information about the llvm-commits mailing list