[PATCH] D75888: [mlir][SideEffects] Mark the CFG only terminator operations as NoSideEffect

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 10:53:06 PDT 2020


rriddle added a comment.

In D75888#1913757 <https://reviews.llvm.org/D75888#1913757>, @mehdi_amini wrote:

> The plan is to get rid of NoSideEffect right? Are you just taking a temporary detour here?


Essentially yes. I'm building up the necessary infra for replacing Operation::hasNoSideEffect with something more powerful. Setting that up will make it much easier to transition things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75888/new/

https://reviews.llvm.org/D75888





More information about the llvm-commits mailing list