[PATCH] D75921: [LLD][DOCS][ELF]Add initial LLD LinkerScript docs page

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 10:19:38 PDT 2020


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/docs/ELF/linker_script.rst:6
+implementation policy is to implement linker script features as they are
+documented in the ld `manual https://sourceware.org/binutils/docs/ld/Scripts.html`
+We consider it a bug if the lld implementation does not agree with the manual
----------------
grimar wrote:
> `index.rst` uses a different formar of URL:
> 
> 
> ```
> `Getting Started with the LLVM System
> <http://llvm.org/docs/GettingStarted.html>`
> ```
> 
> (I just do not know is it important or not, I guess it can be)
Missing a trailing `_`

See https://docutils.sourceforge.io/docs/user/rst/quickref.html#external-hyperlink-targets

Configure with `-DLLVM_ENABLE_SPHINX=on`, then `ninja -C /path/to/build docs-lld-html`. 

It currently fails for me probably because of the version problem:

```
Theme error:
An error happened in rendering the page index.
Reason: TemplateNotFound()
ninja: build stopped: subcommand failed.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75921/new/

https://reviews.llvm.org/D75921





More information about the llvm-commits mailing list