[PATCH] D75131: [XCOFF][AIX] Enable -r option for llvm-objdump

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:25
+  if (!SymNameOrErr)
+    return SymNameOrErr.takeError();
+  StringRef SymName = *SymNameOrErr;
----------------
DiggerLin wrote:
> I  think you can use  function unwrapOrError()
> something like
> StringRef SymbolName =
>       unwrapOrError(Obj.getFileName(), Obj.getSymbolName(SymbolDRI));
unwrapOrError is not suitable for this interface when we actually want to propagate the llvm::Error to the caller.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75131/new/

https://reviews.llvm.org/D75131