[PATCH] D75088: AMDGPU/GlobalISel: Fix some illegal scalar argument types

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 09:12:27 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-function-args.ll:258
+  ; CHECK:   [[DEF:%[0-9]+]]:_(p1) = G_IMPLICIT_DEF
+  ; CHECK:   [[ZEXT:%[0-9]+]]:_(s64) = G_ZEXT [[TRUNC]](s48)
+  ; CHECK:   [[ADD:%[0-9]+]]:_(s64) = G_ADD [[ZEXT]], [[C]]
----------------
foad wrote:
> Isn't the whole point of the `zeroext` attribute that you //don't// need an explicit `G_ZEXT` here? You can just use `[[MV]]` directly.
We need an equivalent of ISD::AssertZext, but don't have it. This is serving as a placeholder


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75088/new/

https://reviews.llvm.org/D75088





More information about the llvm-commits mailing list