[PATCH] D75664: [Coroutines] Also check lifetime intrinsic for local variable when build coroutine frame

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 03:46:45 PDT 2020


junparser updated this revision to Diff 249300.
junparser added a comment.

@wenlei  @modocache  would you please review the updated patch? 
I make the update for :

1. remove assertion since we use lifetime intrinsic as def
2. support multiple lifetime intrinsic
3. it invalidates one case in cppcoro (large number of synchronous completions doesn't result in stack-overflow) since we do not move local variables into frame now @lewissbaker  would please udpate in


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75664/new/

https://reviews.llvm.org/D75664

Files:
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Coroutines/CoroSplit.cpp
  llvm/test/Transforms/Coroutines/coro-split-02.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75664.249300.patch
Type: text/x-patch
Size: 5551 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200310/2503aa56/attachment.bin>


More information about the llvm-commits mailing list