[PATCH] D75889: AMDGPU: Use V_MAC_F32 for fmad.ftz

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:851
+// TODO: Check only no src2 mods?
+class FMADPat <ValueType vt, Instruction inst, SDPatternOperator node>
+  : GCNPat <(vt (node (vt (VOP3NoMods vt:$src0)),
----------------
It's a shame that FMADPat and FMADModsPat take the same arguments but in a different order.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:864
+
+// Prefer mac form when there are no modifiers.
+let SubtargetPredicate = Has16BitInsts in {
----------------
Doesn't this comment belong four lines earlier?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75889/new/

https://reviews.llvm.org/D75889